Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS ARM64 (Apple Silicon) support. #529

Closed
wants to merge 1 commit into from

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 9, 2021

Adds macos_arch option, default to universal x86_64 + arm64.

Note: CI is set to build for x86_64 since macos-11.0 environment is not available.

@DrMoriarty
Copy link

I think it would be useful to add:

if env['platform'] == 'osx':
    arch_suffix = env['macos_arch']

@piiertho
Copy link
Contributor

Hi there !
I wonder why to make a difference for macos arch parameter ?
Arch is not dependant on the os. In a next future we can imagine having windows arm build.
Also engine build does not add platform specific arch argument : https://docs.godotengine.org/fr/stable/development/compiling/compiling_for_osx.html

@DrMoriarty
Copy link

At least the same architecture can be called by different names on different OSes. arm64 for Mac, arm64v8 for Android and so on.
Also on different OSes we have different special cases: fat binaries with multiply archs for Mac or iOS (we called it universal). As far as I know Windows or Android have no universal binaries (even in the same architecture class: for example x86 and x86_64 for Win)
So having many architectures may be justified.

@piiertho
Copy link
Contributor

piiertho commented May 23, 2021

At least the same architecture can be called by different names on different OSes. arm64 for Mac, arm64v8 for Android and so on.
Also on different OSes we have different special cases: fat binaries with multiply archs for Mac or iOS (we called it universal). As far as I know Windows or Android have no universal binaries (even in the same architecture class: for example x86 and x86_64 for Win)
So having many architectures may be justified.

This is a good reason Indeed :D

@alessio-libardi
Copy link

Hello, any update on this?

Thanks for the great work!

@2shady4u
Copy link
Contributor

What's the difference with #584 ?
That PR from @Faless seems to do the same thing? (= Adding support for arm64)

@bruvzg
Copy link
Member Author

bruvzg commented Aug 8, 2021

What's the difference with #584 ?

It is the same as #584 and #587 combined.

@bruvzg bruvzg closed this Aug 8, 2021
@Faless
Copy link
Contributor

Faless commented Aug 8, 2021

It is the same as #584 and #587 combined.

Yeah, my bad, I didn't notice this PR at the time or I would have merged this instead of making a new one 😞

@akien-mga akien-mga added this to the 3.4 milestone Sep 27, 2021
@akien-mga akien-mga modified the milestones: 3.4, 4.0 Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archived enhancement This is an enhancement on the current functionality platform:macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants